Enable direct user edits in the markdown view #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hillary-mutisya
commented
Jun 19, 2025
hillary-mutisya
commented
- Use milkdown as the markdown editor for the markdown agent. This replaces the previous view-only approach
- enable collab and presence awareness features. Host the websocket components needed for this in the view service
- Update the prompts used by the makdown agent to have the LLM return change operations on the document instead of the full document
* integrate milkdown prototype as viewer/editor for markdown * Update bundling implementation * Investigating 404 when accessing api endpoints * Enable collaboration in editing canvas * AI presence indicators * Remove split view * Simplified editor integration * Fix build errors * Update test output streaming * diagrams plugin * Mermaid diagram plugin working in editor * Parse markdown into prosemirror format when adding content from LLM * Fixed content from /test:augment * Inline equations now rendering * Improve spaces in text content * cleanup unused functions and variables * Update styles * Refactor view/site/index.ts to improve maintanability Apply lint and policy fixes * Clean up vite integration * integrating LLM handlers * styling for command content * Remove duplicate content in test flow * Add ability to share URLs Remove debug content panel * Implement Flow 1 & 2 simplification - Phase 1-5 - Enhanced logging for current behavior analysis - Added auto-save mechanism with 2-second batching - Implemented UI command routing from view to agent process - Added IPC protocol for unified LLM processing - Updated frontend to handle new notification format - Consolidated LLM logic in agent process for both CLI and UI flows Key changes: - Flow 1: Agent owns Yjs operations, view handles auto-save - Flow 2: UI commands routed to agent via IPC instead of direct LLM - Single source of truth for AI processing in agent process - Backward compatibility maintained during transition * Fix TypeScript compilation errors - Fixed ActionResult data access with proper type casting - Removed duplicate methods in collaborationManager - Added markdown renderer initialization - Temporarily removed unused auto-save functions (will re-add in Phase 6) - All TypeScript compilation errors resolved Ready for Phase 6 testing and validation * Notification correctly shows error message if calls fail * Clean up comments and logging statements added during debugging * First take at theme support in the editor * Improve presence indicator * Remove obsolete code * Optimize vite build chunks * Fix chunked build Enable view service to start with no filepath provided * Enable file picker for the editor * Setup yjs websocket service inline with the http service for the view * Update agent prompt * reading and writing changes to document * Consolidating yjs docs * Disconnected editing * Duplicate yjs docs - still broken * Update document room name when active document changes * Cleanup LLMIntegrationService.ts that is not needed anymore * cleanup yjs provider scaffolding * Add logging to debug data mismatch * Working edition of LLM-driven editing flow * Cleaning up unused code * SSE processing for LLM document operations * Remove theme switc her Implement auto-save Update AI agenet presence indicator * Remove verbose logging added to help with investigation earlier * Use debug package for diagnostic logging * Remove experimental features not yet hooked up Clean up logging * update dev launcher * Remove unused code * Update dev scripts Remove markdown-it plugins * Delete markdownDocumentSchema.ts * Fix policy warning and apply lint recommendations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.