Skip to content

Conversation memory entity merge stop forcing data to become lower case. #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

curtisman
Copy link
Member

  • Create a new function mergeConcreteEntitiesEx (based on current mergeConcretEntities
    • won't force data to be lower case regardless of whether merge is case-sensitive or not.
    • In the case-insensitive case, it will pick the first version it encountered.
    • The new code avoid extra conversion of concrete entity to merged entity for the RHS and directly merge to and existing merged entity compare to the old code.
    • Added unit test for this new function.
  • TOOD: after more testing for stability, replace mergeConcreteEntities which currently forces all the resulting entity data to be lower case.

@curtisman curtisman changed the title Conversation memory entity merge doesn't for data to be lower case. Conversation memory entity merge stop forcing data to become lower case. Jul 8, 2025
@curtisman curtisman enabled auto-merge July 8, 2025 20:39
@curtisman curtisman added this pull request to the merge queue Jul 8, 2025
Merged via the queue into microsoft:main with commit 5000aba Jul 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant