-
Notifications
You must be signed in to change notification settings - Fork 364
[draft] Upload TAEF test results #5498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
eng/Version.Details.xml
Outdated
@@ -35,6 +35,10 @@ | |||
<Uri>https://dev.azure.com/microsoft/ProjectReunion/_git/WindowsAppSDKClosed</Uri> | |||
<Sha>f52676312ebf1d66ef59731feb4fad29a713a897</Sha> | |||
</Dependency> | |||
<Dependency Name="Microsoft.ProjectReunion.WinUI.TransportPackage" Version="3.0.0-zmain.250527.0-nightly"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Foundation depending on WinUI? That's an inversion of layering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In short, I'm trying to bring the ConvertWttLogToXUnitLog
from WinUI-lift to foundation, making our foundation's pipeline could upload the TAEF test results to ADO page.
Current problem is that "Foundation pipeline will run the TAEF tests, but will neither publish the result as artifact, nor convert the result to xunit format and upload to ADO test tab. (Aggregator will both publish test result to artifact and convert the .wtl file into xunit format and upload to ADO test tab. In this PR I'm trying to make Foundation also handle test results like Aggregator)"
Alex have told me in his memory Aggregator might introduces ConvertWttLogToXUnitLog
from WinUI, so that's the reason why i also depend on WinUI-lift here. I'm trying to use the same file for this conversion.
This PR is still a draft one, I'll modify the title and add a [draft] tag into it. Thank you for sharing your insight! I'll reach out to you offline for more discussion here!
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.