-
Notifications
You must be signed in to change notification settings - Fork 428
[NavLink] Track active state for menu items with an OnClick handler #3999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vnbaaij
wants to merge
3
commits into
dev
Choose a base branch
from
users/vnbaaij/fix-issue-#3992
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 60.4%
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3992. To fix this issue, we need to do the following:
The active class is put on the
<a>
tag that gets created by the standard NavLink component. We have no NavLink in the situation on a FluentNavLink with an OnClick handler, so we must introduce a new element (<span>
) that we can put the class on. This also means we need to re-create the unit test's verified filesThe menu css specifically looks for a.active and then
positioning-region
to draw the active bar. Because we add a span in 1) we need to change the CSSAnd now for the really hard part...how do we know when the menu item with event callback is active? Actually, we don't.
Only way to find out is to do what normally gets done in the standard NavLink component. Sounds trivial but it is actually quite a bit of code (copied and adapted from standard Blazor NavLink component)
This PR implements these steps