Skip to content

tardev-snapshotter: fix regression to allow no signatures #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

jiria
Copy link
Member

@jiria jiria commented Jun 20, 2025

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
  • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Builds on Windows
  • genPolicy only: Updated sample YAMLs' policy annotations, if applicable
Summary

Fix recent regression that started to require signatures. In the preview mode, we want to start the containers even when no signatures can be found.

Refactors the code gently to simplify error reporting.

Associated issues
Links to CVEs
Test Methodology

@jiria jiria force-pushed the jiria/dontenforcesigs branch from 8eeb982 to 2d9386c Compare June 25, 2025 08:13
@jiria jiria changed the title Allow no sigs tardev-snapshotter: fix regression to allow no signatures Jun 25, 2025
@jiria jiria marked this pull request as ready for review June 25, 2025 08:15
@jiria jiria requested a review from a team as a code owner June 25, 2025 08:15
@jiria jiria merged commit 6853947 into erofs-main Jun 25, 2025
15 of 148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants