Skip to content

Jiria/handleunauthenticatedreferrers #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2025

Conversation

jiria
Copy link
Member

@jiria jiria commented Jun 28, 2025

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
  • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Builds on Windows
  • genPolicy only: Updated sample YAMLs' policy annotations, if applicable
Summary

Handles failures when trying to pull referrers from Docker Hub. Improve error logging so full errors are exposed through containerd.

Associated issues
Links to CVEs
Test Methodology

@jiria jiria requested a review from a team as a code owner June 28, 2025 01:03
@@ -914,10 +923,10 @@ impl TarDevSnapshotter {
let mut store = self.store.write().await;
extract_dir = store
.extract_dir_to_write(&key)
.map_err(|e| Status::unknown(format!("failed to create extract dir: {e}")))?;
.map_err(|e| Status::unknown(format!("failed to create extract dir: {e:#}")))?;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does e:# help do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anyhow error uses it to concatenate all the contexts.

@jiria jiria merged commit e1151e5 into erofs-main Jun 28, 2025
8 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants