Skip to content

Commit 250d2c0

Browse files
committed
Remove special handling for getSelection() with Firefox from tests
1 parent d57f194 commit 250d2c0

File tree

3 files changed

+5
-32
lines changed

3 files changed

+5
-32
lines changed

tests/page/elementhandle-select-text.spec.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -22,25 +22,15 @@ it('should select textarea', async ({ page, server, browserName }) => {
2222
const textarea = await page.$('textarea');
2323
await textarea.evaluate(textarea => textarea.value = 'some value');
2424
await textarea.selectText();
25-
if (browserName === 'firefox') {
26-
expect(await textarea.evaluate(el => el.selectionStart)).toBe(0);
27-
expect(await textarea.evaluate(el => el.selectionEnd)).toBe(10);
28-
} else {
29-
expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
30-
}
25+
expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
3126
});
3227

3328
it('should select input', async ({ page, server, browserName }) => {
3429
await page.goto(server.PREFIX + '/input/textarea.html');
3530
const input = await page.$('input');
3631
await input.evaluate(input => input.value = 'some value');
3732
await input.selectText();
38-
if (browserName === 'firefox') {
39-
expect(await input.evaluate(el => el.selectionStart)).toBe(0);
40-
expect(await input.evaluate(el => el.selectionEnd)).toBe(10);
41-
} else {
42-
expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
43-
}
33+
expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
4434
});
4535

4636
it('should select plain div', async ({ page, server }) => {

tests/page/locator-misc-2.spec.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
7878
const textarea = page.locator('textarea');
7979
await textarea.evaluate(textarea => (textarea as HTMLTextAreaElement).value = 'some value');
8080
await textarea.selectText();
81-
if (browserName === 'firefox') {
82-
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionStart)).toBe(0);
83-
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionEnd)).toBe(10);
84-
} else {
85-
expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
86-
}
81+
expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
8782
});
8883

8984
it('should type', async ({ page }) => {

tests/page/retarget.spec.ts

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -239,12 +239,7 @@ it('input value retargeting', async ({ page, browserName }) => {
239239
await expect(target).toHaveValue('bar');
240240

241241
await target.selectText();
242-
if (browserName === 'firefox') {
243-
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionStart)).toBe(0);
244-
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionEnd)).toBe(3);
245-
} else {
246-
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('bar');
247-
}
242+
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('bar');
248243
});
249244
}
250245
});
@@ -270,14 +265,7 @@ it('selection retargeting', async ({ page, browserName }) => {
270265
await expect(page.locator('#target')).toHaveText('foo');
271266

272267
await target.selectText();
273-
if (browserName === 'firefox') {
274-
expect(await page.$eval('#target', target => {
275-
const selection = window.getSelection()!;
276-
return selection.anchorNode === target && selection.focusNode === target;
277-
})).toBe(true);
278-
} else {
279-
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo');
280-
}
268+
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo');
281269
});
282270
}
283271
});

0 commit comments

Comments
 (0)