rename

Author: yury-s

packages/playwright-core/src/protocol/validator.ts

@@ -137,7 +137,7 @@ scheme.SetNetworkCookie = tObject({
   secure: tOptional(tBoolean),
   sameSite: tOptional(tEnum(['Strict', 'Lax', 'None'])),
   partitionKey: tOptional(tString),
-  _chromiumHasCrossSiteAncestor: tOptional(tBoolean),
+  _crHasCrossSiteAncestor: tOptional(tBoolean),
 });
 scheme.NetworkCookie = tObject({
   name: tString,
@@ -149,7 +149,7 @@ scheme.NetworkCookie = tObject({
   secure: tBoolean,
   sameSite: tEnum(['Strict', 'Lax', 'None']),
   partitionKey: tOptional(tString),
-  _chromiumHasCrossSiteAncestor: tOptional(tBoolean),
+  _crHasCrossSiteAncestor: tOptional(tBoolean),
 });
 scheme.NameValue = tObject({
   name: tString,

packages/playwright-core/src/server/chromium/crBrowser.ts

@@ -396,7 +396,7 @@ export class CRBrowserContext extends BrowserContext {
       // this is Chromium specific, see https://chromestatus.com/feature/5144832583663616
       // and https://github.com/explainers-by-googlers/CHIPS-spec.
       if (c.partitionKey) {
-        copy._chromiumHasCrossSiteAncestor = c.partitionKey.hasCrossSiteAncestor;
+        copy._crHasCrossSiteAncestor = c.partitionKey.hasCrossSiteAncestor;
         copy.partitionKey = c.partitionKey.topLevelSite;
       }
       return copy;
@@ -405,7 +405,7 @@ export class CRBrowserContext extends BrowserContext {
 
   async addCookies(cookies: channels.SetNetworkCookie[]) {
     function toChromiumCookie(cookie: channels.SetNetworkCookie) {
-      const { name, value, url, domain, path, expires, httpOnly, secure, sameSite, partitionKey, _chromiumHasCrossSiteAncestor } = cookie;
+      const { name, value, url, domain, path, expires, httpOnly, secure, sameSite, partitionKey, _crHasCrossSiteAncestor } = cookie;
       const copy: Protocol.Network.CookieParam = {
         name,
         value,
@@ -420,8 +420,8 @@ export class CRBrowserContext extends BrowserContext {
       if (partitionKey) {
         copy.partitionKey = {
           topLevelSite: partitionKey,
-          // _chromiumHasCrossSiteAncestor is non-standard, set it true by default if the cookie is partitioned.
-          hasCrossSiteAncestor: _chromiumHasCrossSiteAncestor ?? true,
+          // _crHasCrossSiteAncestor is non-standard, set it true by default if the cookie is partitioned.
+          hasCrossSiteAncestor: _crHasCrossSiteAncestor ?? true,
         };
       }
       return copy;

packages/protocol/src/channels.d.ts

@@ -261,7 +261,7 @@ export type SetNetworkCookie = {
   secure?: boolean,
   sameSite?: 'Strict' | 'Lax' | 'None',
   partitionKey?: string,
-  _chromiumHasCrossSiteAncestor?: boolean,
+  _crHasCrossSiteAncestor?: boolean,
 };
 
 export type NetworkCookie = {
@@ -274,7 +274,7 @@ export type NetworkCookie = {
   secure: boolean,
   sameSite: 'Strict' | 'Lax' | 'None',
   partitionKey?: string,
-  _chromiumHasCrossSiteAncestor?: boolean,
+  _crHasCrossSiteAncestor?: boolean,
 };
 
 export type NameValue = {

packages/protocol/src/protocol.yml

@@ -224,7 +224,7 @@ SetNetworkCookie:
       - Lax
       - None
     partitionKey: string?
-    _chromiumHasCrossSiteAncestor: boolean?
+    _crHasCrossSiteAncestor: boolean?
 
 
 NetworkCookie:
@@ -244,7 +244,7 @@ NetworkCookie:
       - Lax
       - None
     partitionKey: string?
-    _chromiumHasCrossSiteAncestor: boolean?
+    _crHasCrossSiteAncestor: boolean?
 
 
 NameValue:

tests/library/browsercontext-cookies-third-party.spec.ts

@@ -330,7 +330,7 @@ test(`add 'Partitioned;' cookie via API`, async ({ page, context, browserName, h
       secure: true,
       sameSite: 'None',
       partitionKey: 'https://localhost',
-      _chromiumHasCrossSiteAncestor: false
+      _crHasCrossSiteAncestor: false
     } as any,
     {
       name: 'top-level-non-partitioned',
@@ -352,7 +352,7 @@ test(`add 'Partitioned;' cookie via API`, async ({ page, context, browserName, h
       secure: true,
       sameSite: 'None',
       partitionKey: 'https://127.0.0.1',
-      _chromiumHasCrossSiteAncestor: true
+      _crHasCrossSiteAncestor: true
     } as any,
     {
       name: 'frame-non-partitioned',