Skip to content

feat(codegen): add user-data-dir option #35814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 3, 2025

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Apr 30, 2025

Introduces codegen --user-data-dir option to allow specification of an existing browser profile directory to use during codegen.

Resolves #35617.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@yury-s yury-s requested a review from mxschmitt May 19, 2025 21:12
@agg23 agg23 force-pushed the codegen-user-data-dir branch from c69da3c to d73e011 Compare June 5, 2025 15:05

This comment has been minimized.

This comment has been minimized.

@agg23 agg23 requested a review from pavelfeldman June 30, 2025 16:42
@agg23
Copy link
Contributor Author

agg23 commented Jul 1, 2025

@microsoft-github-policy-service rerun

This comment has been minimized.

@agg23 agg23 merged commit c921c38 into microsoft:main Jul 3, 2025
31 of 32 checks passed
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Test results for "tests 1"

1 failed
❌ [webkit-library] › library/inspector/title.spec.ts:35:5 › should update primary page URL when original primary closes @webkit-ubuntu-22.04-node18

7 flaky ⚠️ [chromium-library] › library/chromium/tracing.spec.ts:49:3 › should run with custom categories if provided @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1087:7 › cli codegen record › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144:3 › should keep reduced motion and color emulation after reload @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-trace.spec.ts:397:5 › should work behind reverse proxy @windows-latest-node18-1

47090 passed, 980 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Please allow playwright codegen to launch the browser in normal mode instead of InPrivate/Incognito mode
3 participants