-
Notifications
You must be signed in to change notification settings - Fork 4.4k
chore: make sure dispatchers work with SdkObjects #36158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make sure dispatchers work with SdkObjects #36158
Conversation
Test results for "tests others"5 flaky22031 passed, 523 skipped Merge workflow run. |
This comment has been minimized.
This comment has been minimized.
Test results for "tests 2"12 failed 189 flaky227920 passed, 9168 skipped Merge workflow run. |
The codebase was 90% there, but there were a few instances that were not an SdkObject.
38cc813
to
fb16f0c
Compare
Test results for "tests 1"1 failed 7 flaky39362 passed, 820 skipped Merge workflow run. |
|
||
close() { | ||
this._socket.close(); | ||
eventsHelper.removeEventListeners(this._eventListeners); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes DEBUG=pw:api npm run atest android/device.spec.ts:26
to fail:
SocketSdkObject.close()
gets called'close'
event listeners get immediately removed- The client never receives the actual
'close'
event.
The codebase was 90% there, but there were a few instances that were not an SdkObject.