Skip to content

Revert "fix(network): Include subdomains of localhost when including … #36284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jun 11, 2025

…cookies (#35771)"

This reverts commit c3c842c.

The new test is failing on Windows and macOS:

Error: apiRequestContext.get: getaddrinfo ENOTFOUND a.b.localhost
Call log:
  - → GET http://a.b.localhost:8911/setcookie.html
    - user-agent: Playwright/1.54.0-next (arm64; macOS 14.7) node/18.20 CI/1
    - accept: */*
    - accept-encoding: gzip,deflate,br

    at /Users/runner/work/playwright/playwright/tests/library/global-fetch-cookie.spec.ts:149:17

See https://github.com/microsoft/playwright/actions/runs/15570082779

@yury-s
Copy link
Member Author

yury-s commented Jun 11, 2025

cc @simenbrekken

@yury-s
Copy link
Member Author

yury-s commented Jun 11, 2025

Fixed by #36285

@yury-s yury-s closed this Jun 11, 2025
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:411:5 › screencast › should capture css transformation @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39358 passed, 820 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants