Skip to content

chore: move Page.close() tests to tests/library #36390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jun 20, 2025

Page.close is not supported in WebView2, MCP extension and Android

yury-s added 2 commits June 20, 2025 12:23
Page.close is not supported in WebView2, MCP extension and Android

This comment has been minimized.

This comment has been minimized.

@yury-s yury-s requested a review from dgozman June 20, 2025 21:56
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39450 passed, 823 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s requested a review from mxschmitt June 20, 2025 23:32
@yury-s yury-s merged commit 68d7f66 into microsoft:main Jun 23, 2025
29 checks passed
@yury-s yury-s deleted the test-page-close branch June 23, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants