Skip to content

fix(blob): correctly type pre-1.53 onTestEnd event for attachments #36443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Jun 25, 2025

Fixes #36317.

Poor typing in internal reporters resulted in an incorrect property access created by #35517. Fix the property access and add a test for pre-1.53 blob attachments.

Ideally these types would be improved in a future change.

Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1312:1 › should pick locator in iframe @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @macos-latest-node18-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

46449 passed, 915 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, that looks like a hard bug to catch!

@agg23 agg23 merged commit 735c536 into microsoft:main Jun 26, 2025
32 checks passed
agg23 added a commit that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression]: No data dir in playwright-repot directory after merging blob reports - no screenshots in report
2 participants