chore: use mutation observer to reset hover model #36478
Merged
+79
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Jun 27, 2025
| @@ -1095,16 +1115,19 @@ export class Recorder { | |||
|
|
|||
| this.highlight.appendChild(createSvgElement(this.document, clipPaths)); | |||
| this.overlay?.install(); | |||
| for (const tool of Object.values(this._tools)) | |||
| tool.install?.(); | |||
There was a problem hiding this comment.
Shouldn't this be just this._currentTool.install()? And if so, we can remove that call from the constructor.
| @@ -204,7 +206,23 @@ class RecordActionTool implements RecorderTool { | |||
| return 'pointer'; | |||
| } | |||
|
|
|||
| cleanup() { | |||
| install() { | |||
| this._observer = new MutationObserver(mutations => { | |||
There was a problem hiding this comment.
I believe this does not cross the shadow boundary. Perhaps not resetting hovered model it in random places would work instead?
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Jun 27, 2025
pavelfeldman
force-pushed
the
recorder_mutation
branch
from
2ab9d5b to
3ce2f94
Compare
Test results for "tests 1"6 flaky46472 passed, 931 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.