Skip to content

chore(html): restructure report code #36532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Jul 2, 2025

Follow up to #36520.

Rearranges HTML Reporter code structure to make utility vs actual component code more recognizable.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@@ -137,12 +137,12 @@
fill: var(--color-fg-muted);
}

.trace-link {
.link-trace {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swapping these class names should be the only actual code change.

@agg23 agg23 requested a review from pavelfeldman July 2, 2025 14:42

This comment has been minimized.

@agg23 agg23 force-pushed the html-reporter-links-refactor branch from a1ab735 to d3422ec Compare July 2, 2025 17:37
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Test results for "tests 1"

1 failed
❌ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @webkit-ubuntu-22.04-node18

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1087:7 › cli codegen record › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-library] › library/video.spec.ts:411:5 › screencast › should capture css transformation @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

47080 passed, 980 skipped
✔️✔️✔️

Merge workflow run.

@agg23 agg23 changed the title chore(html): restructure report code structure chore(html): restructure report code Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant