Session restoration can lead to the wrong profile being selected on restore (saved by name rather than guid)

[Frulfump]

Windows Terminal version

1.22.11751.0

Windows build number

10.0.19045.0

Other Software

N/A

Steps to reproduce

1. Start a tab with the profile (C:\WINDOWS\system32\wsl.exe -d Ubuntu). Has this icon(ms-appx:///ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.png) it shows with the default Tux icon.
2. Restart terminal
3. Notice the icon is missing

Seems like it mayyybe could be related to the HTTP(S) no longer allowed changes #19044 I at least noticed the behavior after the release that included that change. (I know that the icon link above is ms-appx: and shouldn't be blocked and it can load the icon at least the first time).

Left tab is one where I restarted terminal and right one is created in the current session.

Expected Behavior

The icon is shown consistently.

Actual Behavior

The icon is not shown after a restart.

[lhecker]

This is the same as #19075. I'll close this as a duplicate for now.

FWIW WSL can extract assets like icons from the distribution. The problem is that your profile is not updated to pick up the extracted icon. It's at %LOCALAPPDATA%\wsl\*\shortcut.ico (right next to the vhdx).

[Frulfump]

@lhecker I don't think it's a dupe they are two different issues, the one you linked to complains about it not being able to use a URL for the icon, here it's using ms-appx which should be allowed even after the PR that removed support for URL only file and ms-* are allowable #19044 ?! The issue you linked should be closed as by design (Closed as not planned) instead?

Can I get the profile to update itself somehow?

I updated the issue description with an image showcasing the issue more clearly. Why can it find the icon and then forget about it?

%LOCALAPPDATA%\wsl\ is empty for me (using Windows 10 22H2 Microsoft Windows NT 10.0.19045.0)

[lhecker]

Oh, I see what you mean now. You're intentionally using the Tux icon. "it shows with the default Tux icon" sounded like a complaint to me. 🙈

[Frulfump]

Ah no it's ok I only use Ubuntu for now and could fix a separate icon later. But would be interested in the issue with %LOCALAPPDATA%\wsl not containing anything and the disappearing icon.

Well not intentionally it's generated with the Tux icon for me I haven't chosen it.

[lhecker]

I'm not super familiar with WSL's versions as I'm practically just another "user" of it. But I do suspect it's because you're using a different version of WSL or installed Ubuntu manually from a .tar or similar. I installed my distributions with wsl install. I'm also using WSLv2 instead of WSLv1. wsl --version for me shows:

WSL version: 2.5.9.0
Kernel version: 6.6.87.2-1
WSLg version: 1.0.66
MSRDC version: 1.2.6074
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.26100.4652

[Frulfump]

The issue isn't with WSL it's with what Terminal is showing (or not showing in this case.)

I don't remember how I installed WSL or chose the Ubuntu dist. I use WSLv2

➜ wsl --version
WSL version: 2.5.9.0
Kernel version: 6.6.87.2-1
WSLg version: 1.0.66
MSRDC version: 1.2.6074
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.19045.6093

[lhecker]

The issue isn't with WSL it's with what Terminal is showing (or not showing in this case.)

Sorry, I didn't make clear that I was responding to your other question:

But would be interested in the issue with %LOCALAPPDATA%\wsl not containing anything.

[DHowett]

@lhecker this seems like it may be related to session restoration, actually:

Left tab is one where I restarted terminal and right one is created in the current session.

@Frulfump between steps 2 and 2 (that is, while Terminal is not running 😁) can you grab a copy of your state.json? It's next to settings.json. (Settings may help as well, but only for figuring out the profile GUIDs)

[Frulfump]

@DHowett here's the state.json

{
	"dismissedMessages" : 
	[
		"deprecated"
	],
	"generatedProfiles" : 
	[
		"{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
		"{51855cb2-8cce-5362-8f54-464b92b32386}",
		"{2c4de342-38b7-51cf-b940-2309a097f518}",
		"{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
		"{574e775e-4f2a-5b96-ac1e-a2962a402336}",
		"{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
		"{2ece5bfe-50ed-5f3a-ab87-5cd4baafed2b}",
		"{5fb123f1-af88-5b5c-8953-d14a8def1978}"
	],
	"persistedWindowLayouts" : 
	[
		{
			"initialPosition" : "359,163",
			"initialSize" : 
			{
				"height" : 681,
				"width" : 1508
			},
			"launchMode" : "default",
			"tabLayout" : 
			[
				{
					"action" : "newTab",
					"commandline" : "C:\\WINDOWS\\system32\\wsl.exe -d Ubuntu",
					"profile" : "Ubuntu",
					"sessionId" : "{304eb68f-03b0-4cf9-914c-a4d9dcd6a760}",
					"startingDirectory" : "~",
					"suppressApplicationTitle" : false,
					"tabTitle" : "Ubuntu"
				}
			]
		}
	],
	"settingsHash" : "77142686ab69835c-01dbf0e4fc88c596"
}

@DHowett UPDATE: I was discussing this issue with a friend and he pointed out that the profile field is name based and I have another profile named Ubuntu (the one that used the https profile icon). It seems like it takes the icon from the first profile it can find with that name, if I change the name of my profile to Ubuntu 2 it works.

So I think the session restoration logic need to use a profile GUID instead of a name here.

What does the sessionId point to couldn't find that GUID anywhere else?