ConPTY: Emit DSR CPR on resize #19089
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
commented
Jul 1, 2025
| @@ -21,13 +21,13 @@ using namespace Microsoft::Console::VirtualTerminal; | |||
| // - hPipe - a handle to the file representing the read end of the VT pipe. | |||
| // - inheritCursor - a bool indicating if the state machine should expect a | |||
| // cursor positioning sequence. See MSFT:15681311. | |||
| VtInputThread::VtInputThread(_In_ wil::unique_hfile hPipe, const bool inheritCursor) : | |||
| VtInputThread::VtInputThread(_In_ wil::unique_hfile hPipe, std::function<void()> capturedCPR) : | |||
There was a problem hiding this comment.
IDK if this approach is ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help terminals with a reflow behavior unlike
the one implemented in ConPTY, such as VS Code.
Closes #18725
Validation Steps Performed
pushed outside the top viewport. Then type something in the prompt.
Cursor is in a consistent position, even if slightly off. ✅