[#7446] Handle special characters followed by digits in http-client-java's CodeNamer.getEnumMemberName #7448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-client-java's CodeNamer.getEnumMemberName
er1c
requested review from
srnagar,
anuchandy,
weidongxu-microsoft,
haolingdong-msft and
XiaofeiCao
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:java
er1c
commented
May 22, 2025
...tor-core/src/main/java/com/microsoft/typespec/http/client/generator/core/util/CodeNamer.java
Show resolved
Hide resolved
|
No changes needing a change description found. |
There was a problem hiding this comment.
Thanks for the contribution Eric!
This was a bug in conversion logic and your fixed definitely improves upon it.
I've let a comment about what we do consistently on some slightly different input like #$100 Gift Card.
BTW, let us know which tool you uses when you encounter this bug (so that we can schedule a release after the fix).
...ore/src/test/java/com/microsoft/typespec/http/client/generator/core/util/CodeNamerTests.java
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.