http-client-java, codegen change, support query param reinjection #7668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
|
You can try these changes here
|
haolingdong-msft
requested review from
srnagar,
anuchandy,
weidongxu-microsoft and
XiaofeiCao
as code owners
...e/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/PagingMetadata.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/PagingMetadata.java
Outdated
Show resolved
Hide resolved
...in/java/com/microsoft/typespec/http/client/generator/core/template/ClientMethodTemplate.java
Outdated
Show resolved
Hide resolved
...lient-java/generator/http-client-generator-test/src/test/java/azure/core/page/PageTests.java
Outdated
Show resolved
Hide resolved
XiaofeiCao
approved these changes
Jun 19, 2025
weidongxu-microsoft
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Azure/autorest.java#3081
Design:
Azure/autorest.java#3081 (comment)
Code change:
nextLinkReInjectedParameterNamesproperty and logics to extract the value fromxmsPageableand put toMethodPageDetails.nextLinkReInjectedParameterNamesproperty and corresponding ctor, getters.addQueryParameterReInjectionLogicand apply to both sync and async paging service client method.