Make the return type of update_stream
match with create_stream
#1380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the return type of
update_stream
onContext
to match withcreate_stream
. I can see how in the most common usecase, one would want to start using the updated stream immediately after - this change would save the network call of getting the stream after the update.Info
is still reachable throughcached_info()
.PS. That's a breaking change. If you prefer to avoid it, I can rename it to
get_or_update_stream
that would matchget_or_create_stream
as well, but leaveupdate_stream
untouched.