Skip to content

Make the return type of update_stream match with create_stream #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rauno56
Copy link

@rauno56 rauno56 commented Mar 5, 2025

Makes the return type of update_stream on Context to match with create_stream. I can see how in the most common usecase, one would want to start using the updated stream immediately after - this change would save the network call of getting the stream after the update. Info is still reachable through cached_info().

PS. That's a breaking change. If you prefer to avoid it, I can rename it to get_or_update_stream that would match get_or_create_stream as well, but leave update_stream untouched.

@Jarema Jarema force-pushed the feat/unify-update-stream branch from 3e3bb7c to 8e5c5dd Compare March 10, 2025 12:40
@rauno56
Copy link
Author

rauno56 commented Mar 19, 2025

Any feedback on this, @Jarema?

@Jarema
Copy link
Member

Jarema commented Mar 19, 2025

I will get back to this near the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants