fix(async-nats): add empty subject check #1402
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
send_publish
function previously did not validate for empty subject strings.This oversight allowed empty subjects to be processed, which caused nats-server to incorrectly route request payloads to the respond box, then resulting in JSON deserialization failures.
like that:
Error: Error { kind: Other, source: Some(Error("data did not match any variant of untagged enum Response", line: 0, column: 0)) }
what this pr do
This PR adds a validation check for empty subjects in the
send_publish
, immediately returning an error when a subject is empty.