Feature #2815 & #3146 : adding transverse file filter

- fixing some bad behaviors on creation or updating of messages from the Forums applications
- refactoring some code

Author: SilverYoCha

forums/forums-war/src/main/java/com/stratelia/webactiv/forums/control/ForumsSessionController.java

@@ -445,7 +445,7 @@ public int createMessage(String title, String author, int forumId, int parentId,
     String status = STATUS_FOR_VALIDATION;
 
     MessagePK messagePK = new MessagePK(getComponentId(), getSpaceId());
-    int messageId;
+    int messageId = 0;
 
     try {
       if (!isValidationActive() || admin.isInRole(getUserRoleLevel()) ||
@@ -455,8 +455,9 @@ public int createMessage(String title, String author, int forumId, int parentId,
       // creation du message dans la base
       messageId = getForumsBM().createMessage(messagePK, truncateTextField(title),
           author, null, forumId, parentId, text, keywords, status);
-    } catch (ForumsException e) {
-      throw new EJBException(e.getMessage(), e);
+    } catch (Exception e) {
+      SilverpeasTransverseErrorUtil.stopTransverseErrorIfAny(new EJBException(e.getMessage(), e));
+      return messageId;
     }
     messagePK.setId(String.valueOf(messageId));
 
@@ -502,8 +503,9 @@ public void updateMessage(int messageId, String title, String text, String statu
       }
       getForumsBM().updateMessage(messagePK, truncateTextField(title), text,
           getUserId(), currentStatus);
-    } catch (ForumsException e) {
-      throw new EJBException(e.getMessage(), e);
+    } catch (Exception e) {
+      SilverpeasTransverseErrorUtil.stopTransverseErrorIfAny(new EJBException(e.getMessage(), e));
+      return;
     }
 
     // Send notification to subscribers

forums/forums-war/src/main/java/com/stratelia/webactiv/forums/control/helpers/ForumActionHelper.java

@@ -209,15 +209,12 @@ private static void actionManagement(int action, int params, HttpServletRequest
             if (StringUtil.isDefined(messageTitle) && StringUtil.isDefined(messageText)) {
               Collection<UploadedFile> uploadedFiles = FileUploadManager.getUploadedFiles(request,
                   fsc.getUserDetail());
-              int result =
+              int messageId =
                   fsc.createMessage(messageTitle, userId, forumId, parentId, messageText,
                       forumKeywords, uploadedFiles);
-              if (subscribe == null) {
-                subscribe = "0";
-              } else {
-                subscribe = "1";
-                if (result != 0) {
-                  fsc.subscribeMessage(result);
+              if (subscribe != null) {
+                if (messageId != 0) {
+                  fsc.subscribeMessage(messageId);
                 }
               }
               if (parentId > 0) {

silvercrawler/silvercrawler-war/src/main/java/com/silverpeas/silvercrawler/control/SilverCrawlerSessionController.java

@@ -55,6 +55,7 @@
 import org.silverpeas.search.searchEngine.model.MatchingIndexEntry;
 import org.silverpeas.search.searchEngine.model.QueryDescription;
 import org.silverpeas.util.UnitUtil;
+import org.silverpeas.util.memory.MemoryUnit;
 
 import java.io.File;
 import java.io.IOException;
@@ -243,7 +244,7 @@ public FolderZIPInfo zipFolder(String folderName) {
     SilverTrace.debug("silverCrawler", "SilverCrawlerSessionController.zipFolder()",
         "root.MSG_GEN_PARAM_VALUE", "fileZip = " + zipFile.getName());
 
-    long sizeMax = UnitUtil.convertTo(getSizeMax(), UnitUtil.memUnit.MB, UnitUtil.memUnit.B);
+    long sizeMax = UnitUtil.convertTo(getSizeMax(), MemoryUnit.MB, MemoryUnit.B);
     long zipSize = 0;
     String url = "";
     SilverTrace.debug("silverCrawler",