Skip to content

Commit 238fbec

Browse files
committed
Bug #5095 : fixing technical error from Quizz application.
1 parent ad88a9e commit 238fbec

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

quizz/quizz-war/src/main/java/com/stratelia/webactiv/quizz/control/QuizzSessionController.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -666,13 +666,13 @@ public List<ComponentInstLight> getGalleries() {
666666
List<ComponentInstLight> galleries = null;
667667
OrganisationController orgaController = new OrganizationController();
668668
String[] compoIds = orgaController.getCompoId("gallery");
669-
for (int c = 0; c < compoIds.length; c++) {
670-
if ("yes".equalsIgnoreCase(orgaController.getComponentParameterValue("gallery" + compoIds[c],
671-
"viewInWysiwyg"))) {
669+
for (final String compoId : compoIds) {
670+
if ("yes".equalsIgnoreCase(
671+
orgaController.getComponentParameterValue("gallery" + compoId, "viewInWysiwyg"))) {
672672
if (galleries == null) {
673673
galleries = new ArrayList<ComponentInstLight>();
674674
}
675-
ComponentInstLight gallery = orgaController.getComponentInstLight("gallery" + compoIds[c]);
675+
ComponentInstLight gallery = orgaController.getComponentInstLight("gallery" + compoId);
676676
galleries.add(gallery);
677677
}
678678
}

quizz/quizz-war/src/main/webapp/quizz/jsp/questionCreator.jsp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -612,14 +612,15 @@ if ((action.equals("CreateQuestion")) || (action.equals("SendQuestionForm"))) {
612612

613613
<div class="thumbnailInputs">
614614
<img title="<%=resources.getString("survey.answer.image.select")%>" alt="<%=resources.getString("survey.answer.image.select")%>" src="/silverpeas/util/icons/images.png" /> <input type="file" id="thumbnailFile" size="40" name="image<%=i%>" />
615+
<%if (galleries != null) {%>
615616
<span class="txtsublibform"> ou </span><input type="hidden" name="valueImageGallery<%= i %>" id="valueImageGallery<%= i %>"/>
616617
<select class="galleries" name="galleries" onchange="choixGallery(this, '<%= i %>');this.selectedIndex=0;">
617618
<option selected><%= resources.getString("survey.galleries") %></option>
618619
<%
619-
for (int k = 0; k < galleries.size(); k++) {
620-
ComponentInstLight gallery = galleries.get(k); %>
620+
for (ComponentInstLight gallery : galleries) { %>
621621
<option value="<%= gallery.getId() %>"><%= gallery.getLabel() %></option>
622-
<% } %>
622+
<% }
623+
} %>
623624
</select>
624625
</div>
625626
</div>

quizz/quizz-war/src/main/webapp/quizz/jsp/questionCreatorBis.jsp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -508,14 +508,15 @@ if ((action.equals("CreateQuestion")) || (action.equals("SendQuestionForm"))) {
508508

509509
<div class="thumbnailInputs">
510510
<img title="<%=resources.getString("survey.answer.image.select")%>" alt="<%=resources.getString("survey.answer.image.select")%>" src="/silverpeas/util/icons/images.png" /> <input type="file" id="thumbnailFile" size="40" name="image<%=i%>" />
511+
<%if (galleries != null) {%>
511512
<span class="txtsublibform"> ou </span><input type="hidden" name="valueImageGallery<%= i %>" id="valueImageGallery<%= i %>"/>
512513
<select class="galleries" name="galleries" onchange="choixGallery(this, '<%= i %>');this.selectedIndex=0;">
513514
<option selected><%= resources.getString("survey.galleries") %></option>
514515
<%
515-
for (int k = 0; k < galleries.size(); k++) {
516-
ComponentInstLight gallery = galleries.get(k); %>
516+
for (ComponentInstLight gallery : galleries) { %>
517517
<option value="<%= gallery.getId() %>"><%= gallery.getLabel() %></option>
518-
<% } %>
518+
<% }
519+
} %>
519520
</select>
520521
</div>
521522
</div>

0 commit comments

Comments
 (0)