Skip to content

Commit 5fc0508

Browse files
committed
Merge pull request vpulim#472 from herom/master
Updated CONTRIBUTING.md
2 parents a93898a + d69980d commit 5fc0508

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ Because SOAP Web Services can differ amongst implementations, there is high risk
1212

1313
##Submitting a Pull Request
1414
* Pull Requests must be rebased to the latest version of master and squashed to a single commit i.e. `git checkout master;git pull upstream master;git checkout feature-branch;git rebase -i master`
15+
* Pull Requests must have accompanying tests (either Unit or Request/Response Sample tests are welcome). Your chances of getting the PR merged are very low if you don't provide any tests.
1516
* Pull Requests must have passing travis builds.
1617
* Pull Requests must be able to merge automatically from github.
1718
* Please do not close a pull request due to a request to rebase. Git is a powerful VCS and deserves your time in learning how to rebase properly. Pull Requests are updated automatically on github when you force push to your branch after rebasing.

0 commit comments

Comments
 (0)