Merge pull request vpulim#522 from Mik13/master

Use correct namespaces for elements which consist of an array.

Author: herom

lib/wsdl.js

@@ -1424,6 +1424,12 @@ WSDL.prototype.objectToXML = function(obj, name, namespace, xmlns, first, xmlnsA
   var self = this;
   var schema = this.definitions.schemas[xmlns];
 
+  var parentNamespace = namespace ? namespace.parent : undefined;
+  if(parentNamespace) {
+    //we got the parentNamespace for our array. setting the namespace-variable back to the current namespace string
+    namespace = namespace.current;
+  }
+
   var soapHeader = !schema;
   var qualified = schema && schema.$elementFormDefault === 'qualified';
   var parts = [];
@@ -1456,10 +1462,12 @@ WSDL.prototype.objectToXML = function(obj, name, namespace, xmlns, first, xmlnsA
 
   if (Array.isArray(obj)) {
     for (var i = 0, item; item = obj[i]; i++) {
-      var arrayAttr = self.processAttributes(item);
-      parts.push(['<', ns, name, arrayAttr, xmlnsAttrib, '>'].join(''));
+      var arrayAttr = self.processAttributes(item),
+          correctOuterNamespace = parentNamespace || ns; //using the parent namespace if given
+
+      parts.push(['<', correctOuterNamespace, name, arrayAttr, xmlnsAttrib, '>'].join(''));
       parts.push(self.objectToXML(item, name, namespace, xmlns, false, null, parameterTypeObject, ancXmlns));
-      parts.push(['</', ns, name, '>'].join(''));
+      parts.push(['</', correctOuterNamespace, name, '>'].join(''));
     }
   } else if (typeof obj === 'object') {
     for (name in obj) {
@@ -1522,6 +1530,14 @@ WSDL.prototype.objectToXML = function(obj, name, namespace, xmlns, first, xmlnsA
                 }
               }
 
+              if(Array.isArray(child)) {
+                //for arrays, we need to remember the current namespace
+                childNamespace = {
+                  current: childNamespace,
+                  parent: ns
+                };
+              }
+
               value = self.objectToXML(child, name, childNamespace, childXmlns, false, childXmlnsAttrib, completeChildParameterTypeObject, ancXmlns);
             } else if (obj[self.options.attributesKey] && obj[self.options.attributesKey].xsi_type) { //if parent object has complex type defined and child not found in parent
               var completeChildParamTypeObject = self.findChildParameterObjectFromSchema(obj[self.options.attributesKey].xsi_type.type, obj[self.options.attributesKey].xsi_type.xmlns);

test/request-response-samples/addList__complex_extension_namespace_for_arrays/request.xml

@@ -1 +1 @@
-<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"  xmlns:tns="urn:platform_2013_2.webservices.netsuite.com" xmlns:platformMsgs="urn:messages_2013_2.platform.webservices.netsuite.com" xmlns:platformFaults="urn:faults_2013_2.platform.webservices.netsuite.com"><soap:Body><platformMsgs:addList xmlns:platformMsgs="urn:messages_2013_2.platform.webservices.netsuite.com" xmlns="urn:messages_2013_2.platform.webservices.netsuite.com"><platformCore:record xsi:type="ns1:Contact" xmlns:ns1="urn:relationships_2013_2.lists.webservices.netsuite.com" xmlns:platformCore="urn:core_2013_2.platform.webservices.netsuite.com"><ns1:firstName>First-1400867779067</ns1:firstName><ns1:lastName>Sullivan</ns1:lastName><ns1:phone>800-555-2819</ns1:phone><ns1:subsidiary internalId="1" xsi:type="ns2:RecordRef" xmlns:ns2="urn:core_2013_2.platform.webservices.netsuite.com"></ns1:subsidiary></platformCore:record><platformCore:record xsi:type="ns3:Contact" xmlns:ns3="urn:relationships_2013_2.lists.webservices.netsuite.com" xmlns:platformCore="urn:core_2013_2.platform.webservices.netsuite.com"><ns3:firstName>aLFirst-1400867779067</ns3:firstName><ns3:lastName>Sullivan</ns3:lastName><ns3:phone>800-555-2819</ns3:phone><ns3:subsidiary internalId="1" xsi:type="ns4:RecordRef" xmlns:ns4="urn:core_2013_2.platform.webservices.netsuite.com"></ns3:subsidiary></platformCore:record></platformMsgs:addList></soap:Body></soap:Envelope>
+<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"  xmlns:tns="urn:platform_2013_2.webservices.netsuite.com" xmlns:platformMsgs="urn:messages_2013_2.platform.webservices.netsuite.com" xmlns:platformFaults="urn:faults_2013_2.platform.webservices.netsuite.com"><soap:Body><platformMsgs:addList xmlns:platformMsgs="urn:messages_2013_2.platform.webservices.netsuite.com" xmlns="urn:messages_2013_2.platform.webservices.netsuite.com"><platformMsgs:record xsi:type="ns1:Contact" xmlns:ns1="urn:relationships_2013_2.lists.webservices.netsuite.com" xmlns:platformCore="urn:core_2013_2.platform.webservices.netsuite.com"><ns1:firstName>First-1400867779067</ns1:firstName><ns1:lastName>Sullivan</ns1:lastName><ns1:phone>800-555-2819</ns1:phone><ns1:subsidiary internalId="1" xsi:type="ns2:RecordRef" xmlns:ns2="urn:core_2013_2.platform.webservices.netsuite.com"></ns1:subsidiary></platformMsgs:record><platformMsgs:record xsi:type="ns3:Contact" xmlns:ns3="urn:relationships_2013_2.lists.webservices.netsuite.com" xmlns:platformCore="urn:core_2013_2.platform.webservices.netsuite.com"><ns3:firstName>aLFirst-1400867779067</ns3:firstName><ns3:lastName>Sullivan</ns3:lastName><ns3:phone>800-555-2819</ns3:phone><ns3:subsidiary internalId="1" xsi:type="ns4:RecordRef" xmlns:ns4="urn:core_2013_2.platform.webservices.netsuite.com"></ns3:subsidiary></platformMsgs:record></platformMsgs:addList></soap:Body></soap:Envelope>