Feat/new UI assets management #2270
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -318,6 +318,8 @@ export class SandboxManager { | |||
|
|
|||
| async writeBinaryFile(path: string, content: Buffer | Uint8Array): Promise<boolean> { | |||
| const normalizedPath = normalizePath(path); | |||
| console.log('normalizedPath', normalizedPath); | |||
There was a problem hiding this comment.
Remove the debug log (console.log('normalizedPath', normalizedPath)) before merging to production.
| console.log('normalizedPath', normalizedPath); |
.../web/client/src/app/project/[id]/_components/left-panel/image-tab/hooks/use-folder-images.ts
Show resolved
Hide resolved
| } | ||
|
|
||
| for (const [, subfolder] of folder.children) { | ||
| moveSubfolder(subfolder, newPath, session); |
There was a problem hiding this comment.
The recursive call to moveSubfolder in moveFolderContents is not awaited, which might lead to unhandled async behavior. Consider awaiting the call or handling its errors explicitly.
| moveSubfolder(subfolder, newPath, session); | |
| await moveSubfolder(subfolder, newPath, session); |
...client/src/app/project/[id]/_components/left-panel/image-tab/folder/folder-dropdown-menu.tsx
Outdated
Show resolved
Hide resolved
spartan-vutrannguyen
force-pushed
the
feat/new-ui-assets-management
branch
from
47d7587 to
ece1850
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/web/client/src/app/project/[id]/_components/left-panel/image-tab/image-item.tsx
Outdated
Show resolved
Hide resolved
| import { useEditorEngine } from '@/components/store/editor'; | ||
| import { useImagesContext } from '../providers/images-provider'; | ||
|
|
||
| export const useImageDragDrop = (currentFolder?: string) => { |
There was a problem hiding this comment.
Looks like this still needs to be implemented?
| editorEngine.state.editorMode = EditorMode.DESIGN; | ||
| }, [editorEngine.state]); | ||
|
|
||
| const onImageDragEnd = useCallback(() => { |
* add folder features * update upload function * add confirm modal
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Introduce new UI for managing image assets with folder and image operations, updating related logic and components.
folder-dropdown-menu.tsx,folder-dropdown.tsx,folder-list.tsx,folder-tab.tsx, andindex.tsx.image-dropdown-menu.tsx,image-item.tsx, andimage-list.tsx.folder-create-modal.tsx,folder-delete-modal.tsx,folder-move-modal.tsx, andfolder-rename-modal.tsx.use-folder-images.ts,use-folder.ts,use-image-delete.ts,use-image-drag-drop.ts,use-image-loading.ts,use-image-move.ts,use-image-rename.ts,use-image-search.ts, anduse-image-upload.ts.IMAGE_FOLDERdefault topublicinconstants/src/editor.ts.ImageManagerinimage/index.tsto handle new folder structure.SandboxManagerinsandbox/index.tsto support file renaming and moving.MoveToFoldericon inicons/index.tsx.settings-modalcomponents to use new image management logic.This description was created by
for 06989ad. You can customize this summary. It will automatically update as commits are pushed.