poc: state machine for file management #2279
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| this.pendingWrites.delete(filePath); | ||
| this.setState(filePath, 'dirty'); | ||
| // Schedule another sync for the pending content | ||
| this.scheduleRemoteSync(filePath, pendingContent, writeRemote); |
There was a problem hiding this comment.
Consider awaiting the recursive call to scheduleRemoteSync so that errors and order are properly propagated instead of fire-and-forget.
Suggested change
| this.scheduleRemoteSync(filePath, pendingContent, writeRemote); | |
| await this.scheduleRemoteSync(filePath, pendingContent, writeRemote); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Introduce
StateMachineFileSyncManagerfor file synchronization with state management and integrate it intoSandboxManager.StateMachineFileSyncManagerinfile-sync-state-machine.tsto manage file states ('clean', 'dirty', 'syncing', 'conflict').saveFile(),saveBinaryFile(),onRemoteChange(), and conflict resolution methods.FileSyncManagerwithStateMachineFileSyncManagerinSandboxManagerinindex.ts.writeFile(),writeBinaryFile(), andhandleFileChange()to use the new state machine.state-machine-file-sync.test.tswith tests for file operations, state transitions, conflict detection/resolution, and storage persistence.This description was created by
for 1a784a5. You can customize this summary. It will automatically update as commits are pushed.