Use source generators for semantic conventions #2869
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2869 +/- ##
==========================================
- Coverage 73.91% 69.76% -4.15%
==========================================
Files 267 394 +127
Lines 9615 15980 +6365
==========================================
+ Hits 7107 11149 +4042
- Misses 2508 4831 +2323 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
thompson-tomo
force-pushed
the
feature/#2856_SourceGenerator
branch
from
36ccb43 to
fa3632f
Compare
thompson-tomo
force-pushed
the
feature/#2856_SourceGenerator
branch
from
fa3632f to
b481fee
Compare
thompson-tomo
changed the title
thompson-tomo
force-pushed
the
feature/#2856_SourceGenerator
branch
3 times, most recently
from
2705087 to
5bc6f77
Compare
thompson-tomo
force-pushed
the
feature/#2856_SourceGenerator
branch
4 times, most recently
from
b5a6bb4 to
3ed9eb5
Compare
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
thompson-tomo
force-pushed
the
feature/#2856_SourceGenerator
branch
from
3ed9eb5 to
2c96664
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Keep open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2856
Design discussion issue #
Changes
This PR introduces a new client package
OpenTelemetry.SemanticConventions.Abstractionswhich is designed to ease the implementation of otel by reducing the need for implementors to be defining their own keys.The approach here overcomes the limitation of the current approach by Scoping the generated code to the users namespace and the accessibility modifier being internal. At the same time it is only generating the necessary namespace.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes