-
Notifications
You must be signed in to change notification settings - Fork 829
Add Tadas Stasiulionis to Contributors list #6348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Tadas Stasiulionis to Contributors list #6348
Conversation
The committers listed above are authorized under a signed CLA. |
@@ -19,7 +19,7 @@ on how to become a | |||
and | |||
[**Maintainer**](https://github.com/open-telemetry/community/blob/main/community-membership.md#maintainer). | |||
|
|||
## Find a buddy and get started quickly | |||
## Find a buddy and get started quickly, - Tadas Stasiulionis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tstasiulionis It is not clear what your goal is with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just followed the "first open source" contribution tutorial by github, and made a quick pull request as noted in the instructions. I thought that this open source project would be cool to work on and learn. Although I have only completed 2-3 weeks of undergraduate term at Kaunas University of Technology on System engineering and c#.
I am a self tought software engineer since 2015, main goal to contribute to this open source project is to have fun and learn. It is my first Open Source project, but I have worked with languages like lua + web dev langs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s my undergraduate degree is in Humanitarian Sciences :)))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you wanting to get involved in open source is commendable, this isn't the type of change you should make to go about to do that (for any project, not just this one). Maybe you misunderstood the tutorial and meant to just change your fork of the project, not submit the change from your fork to this repository (what would typically be called the upstream of your fork).
Adjusting formatting just for the sake of changing it isn't valuable to this project, and there's no reason to put your name in the contributing guide at all from this project's perspective.
A good way to get started is to either look at topic such as good-first-issue to see if there's a piece of work that contributions are actively sought for, or if you find a genuine mistake in some documentation (like a typo) that you can fix.
Fixes #
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes