Move npm-check commands from style-guide.md to pr-checks.md #7191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #6601
As raised in #6601, it's not intuitive to have the npm checks commands listed on the Style guide page. We should probably move them to Pull request checks page or create a new one.
By taking a closer look at both pages, most of the commands described on the
style-guide.md
page are also onpr-checks.md
:style-guide.md
pr-checks.md
npm run fix:all
npm run check:text
npm run check:text -- --fix
npm run check:markdown
npm run fix:markdown
npm run check:spelling
npm run fix:dict
npm run fix:format
npm run fix:filenames
Proposal
style-guide.md
Fixing validation issues
, leading to the Pull request checks page.pr-checks.md
Include the previously missing commands (
npm run fix:markdown
andnpm run check:spelling
).The only command left in style-guide.md, at least for now, is npm run fix:format in the File format section. Does it make sense to keep it where we mention Prettier?