Skip to content

Make sure OIDC dynamic tenant update tests run #48802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Jul 6, 2025

Somehow, in #48278, I managed to lose the update now brought in by this PR, without it the tests are not run, I probably missed adding a commit...

Copy link

quarkus-bot bot commented Jul 6, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 71b3481.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand requested a review from michalvavrik July 7, 2025 06:24
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need doTestCodeFlowUserInfoDynamicGithubUpdate called. I didn't mention this in the original PR, sorry.

@sberyozkin
Copy link
Member Author

Thanks @michalvavrik, no, it was totally my fault, it was most likely available in the draft PR, and then I somehow managed to lose it :-)

@geoand, it should be ready to go :-)

@geoand geoand merged commit ba9aab1 into quarkusio:main Jul 7, 2025
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jul 7, 2025
@sberyozkin sberyozkin deleted the fix_oidc_dynamic_tenant_update_test branch July 7, 2025 08:49
@gsmet gsmet modified the milestones: 3.25 - main, 3.24.3 Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants