Issue 172: Support for sh:closed sh:ByTypes
#399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergos
approved these changes
Jun 8, 2025
Co-authored-by: Thomas Bergwinkl <bergos@users.noreply.github.com>
TallTed
changed the title
sh:closed sh:ByTypes
TallTed
requested changes
Jun 11, 2025
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
YoucTagh
approved these changes
Jun 15, 2025
shacl12-core/index.html
Outdated
| function collectProperties(S) | ||
| add all IRI properties that can be reached from S via the SPARQL path | ||
| sh:property/sh:path | ||
| if S is a SHACL instance of rdfs:Class in the shapes graph { |
There was a problem hiding this comment.
Is rdfs:Class correct to use here, in light of the lengthy discussion on #212 ?
There was a problem hiding this comment.
I think so, but what in particular are you concerned about?
shacl12-core/index.html
Outdated
Comment on lines
6153
to
6155
| if S is a SHACL instance of sh:NodeShape in the shapes graph | ||
| for each triple in the shapes graph matching (S sh:node ?o) | ||
| collectProperties(?o) |
There was a problem hiding this comment.
sh:node can also go on a sh:PropertyShape. So should "if S is a SHACL instance of sh:NodeShape in the shapes graph" instead read "if S is a SHACL instance of sh:NodeShape or sh:PropertyShape in the shapes graph"?
There was a problem hiding this comment.
According to the syntax rules, the values of sh:node must be well-formed node shapes, not property shapes. If you want property shapes there, nest them inside a node shape via sh:property.
TallTed
reviewed
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172