Deploying a function does not respect the cleanup policy and deletes old containers

[canbal]

[REQUIRED] Environment info

firebase-tools: 14.1.0

Platform: macOS

[REQUIRED] Test case

This has been supported in the past as an experimental configuration since #6861, but #8324 has removed it with the assumption that cleanup policy should be respected instead. In my case the clean-up policy is not respected and the new function deploys always destroy previous containers.

For reference, here's the policy I have set in my project:

[REQUIRED] Steps to reproduce

1. Deploy a new function: firebase deploy --only functions:myFunction
2. Go to Cloud Run console > myFunction > Revisions to see the revisions
3. Click on a previous revision that was created sooner than the clean-up period
4. Go to Container > Image and click on it
5. See the page shows "Unable to find the resource you requested"

[REQUIRED] Expected behavior

Any revision that was created before the clean-up period comes along should be available

[REQUIRED] Actual behavior

The previous revisions are all removed immediately followed by a successful new deployment

[google-oss-bot]

This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information.

[aalej]

Hey @canbal, I'm trying to reproduce this, but so far previous revisions are not being deleted on successful function deployments.

Here's the clean up policy I have set up:

And here's the revisions for the function. The container images from each revision is still available when opening the link

Based on the clean up policy you have set, only artifacts older than 10 days should be deleted. Just to verify, in your case, after running firebase deploy --only functions:myFunction are the images from old revisions immediately deleted even if they're less than 10 days old?

By any chance, do you have any other clean up policy set up?

[canbal]

Thanks for checking @aalej. I don't have another clean up policy set up, the one I shared is the only one. However I have a couple of new observations:

1. I tried to deploy a completely brand new function under the name myFunction and I can confirm the previous image is still intact. For a brand new function things seems to be working.
2. I tried to deploy an existing function (not sure if relevant but it was created prior to when the policy was created) with firebase deploy --only functions:existingFunction and for that one the previous image is erased immediately.

Is there a local cache I have to clear, or is it possible that the policy somehow isn't properly covering specific functions?

If there is a way to run a gcloud command or run a script to fetch the policy that the cli tool is relying on, I'd be happy to run it and report back.

[canbal]

@aalej not sure what changed, but it seems like the older images are now retained even for the existing functions. We can close this issue.