[nnx] add JitWrapped API #4699
Open
[nnx] add JitWrapped API #4699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-jitwrapped
branch
2 times, most recently
from
8fb0f2c to
4bc81f2
Compare
cgarciae
force-pushed
the
nnx-jitwrapped
branch
from
4bc81f2 to
447c73e
Compare
IvyZX
reviewed
Apr 18, 2025
| querying properties of lowered computations across JAX's various | ||
| lowering paths (:func:`~jax.jit`, :func:`~jax.pmap`, etc.). | ||
| """ | ||
| lowered: jax._src.stages.Lowered |
There was a problem hiding this comment.
Use jax.stages.Lowered to avoid using internal APIs
| common API for querying properties of compiled computations across | ||
| JAX's various compilation paths and backends. | ||
| """ | ||
| compiled: jax._src.stages.Compiled |
There was a problem hiding this comment.
Use external API if possible, same for other types
| return self._inner_obj.donate_argnums | ||
|
|
||
| @dataclasses.dataclass(frozen=True, slots=True) | ||
| class Compiled(Stage): |
There was a problem hiding this comment.
Question: why not subclass JAX's Stage, Compiled, etc? Looks easier than creating new classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
nnx.jitnow returns aJitWrappedobject that mimics the behavior from the JAX counterpart.