Skip to content

Kotlin DSL Support #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scottroemeschke opened this issue Oct 16, 2018 · 4 comments · Fixed by #441
Closed

Kotlin DSL Support #184

scottroemeschke opened this issue Oct 16, 2018 · 4 comments · Fixed by #441

Comments

@scottroemeschke
Copy link

scottroemeschke commented Oct 16, 2018

Are there plans to officially support the Kotlin Gradle DSL now that it is 1.0?

https://blog.gradle.org/gradle-kotlin-dsl-release-candidate

instead of having to write code like:

publish(delegateClosureOf<PublisherConfig> {
    repository(delegateClosureOf<GroovyObject> {
      setProperty("repoKey", "libs-release-local")
      setProperty("username", ArtifactoryCredentials.getCredentials(properties))
      setProperty("password", ArtifactoryCredentials.getCredentials(properties))
      setProperty("maven", true)
    })
@yahavi yahavi linked a pull request Mar 2, 2021 that will close this issue
1 task
@clayly
Copy link

clayly commented Mar 25, 2021

Two years passed. Is there anyone? Is this project abandoned or something? We deciding whether we should use Artifactory, and lack of clear documentation, broken examples and absence of support for quite ordinal features like Kotlin DSL looks like bad sign for me.

@gildor
Copy link

gildor commented Mar 26, 2021

You don't need this plugin to use Artifactory, Artifactory is great solutions itself, but to publish something to it just use standard Gradle publishing plugins, so for maven dependencies just use the standard Gradle maven-publish plugin, which not only works fine for Kotlin DSL, but also supports publishing Gradle Metadata

This plugin always was quite redundant and not very useful

If you really want to set some custom Artifactory properties for some reason, just write a custom task with simple POST request, it's easier than use this plugin and it doesn't break normal Gradle publishing flow

@clayly
Copy link

clayly commented Mar 26, 2021

You don't need this plugin to use Artifactory, Artifactory is great solutions itself, but to publish something to it just use standard Gradle publishing plugins, so for maven dependencies just use the standard Gradle maven-publish plugin, which not only works fine for Kotlin DSL, but also supports publishing Gradle Metadata

This plugin always was quite redundant and not very useful

If you really want to set some custom Artifactory properties for some reason, just write a custom task with simple POST request, it's easier than use this plugin and it doesn't break normal Gradle publishing flow

I hear it for the first time. This important info absent in documentation:

And even worse, all the starting guides and examples uses it:

And even even worse, none of this examples is working.

You can imagine that this is highly unpleasant experience. In the first place for those articles which everyone who trying to start with Artifactory will use.

Please consider update those examples / documentation / plugin / JFrog CLI.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Mar 26, 2021

This pull request -
#441 was kindly contributed by @sugarmanz and I believe it will be merged soon. It adds Kotlin DSL support.

As for the issues you experienced with the plugin examples, I've just tried some of them and they worked as expected. I'd be happy to assist you using them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants