Skip to content

ArtifactoryTask: Add proper gradle annotations to avoid 6.x warnings #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rpalcolea
Copy link
Contributor

Hi

This pull request fixes the following warnings when using Gradle 6.x:

> Task :build-info-extractor-gradle:validatePlugins FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':build-info-extractor-gradle:validatePlugins'.
> Plugin validation failed. See https://docs.gradle.org/6.1-20191004133052+0000/userguide/more_about_tasks.html#sec:task_input_output_annotations for more information on how to annotate task properties.
   > Warning: Type 'ArtifactoryTask': field 'mavenPublications' without corresponding getter has been annotated with @Input, @Optional.
   > Warning: Type 'ArtifactoryTask': field 'publishConfigs' without corresponding getter has been annotated with @InputFiles, @Optional.
   > Warning: Type 'ArtifactoryTask': property 'deployDetails' is not annotated with an input or output annotation.
   > Warning: Type 'ArtifactoryTask': property 'evaluated' is not annotated with an input or output annotation.

It would be great if we could get this one merged soon :)

cc / @ljacomet

@rpalcolea rpalcolea force-pushed the ArtifactoryTask-proper-gradle-annotations branch from d832161 to a40e735 Compare October 4, 2019 19:36
@rpalcolea rpalcolea changed the title Add proper gradle annotations to avoid 6.x warnings ArtifactoryTask: Add proper gradle annotations to avoid 6.x warnings Oct 4, 2019
@rpalcolea
Copy link
Contributor Author

@eyalbe4 @yahavi ^^

@danhyun
Copy link

danhyun commented Oct 10, 2019

@yahavi thanks for your work on jfrog/artifactory-client-java#261, do you think we can get this one landed as well?

@eyalbe4
Copy link
Contributor

eyalbe4 commented Oct 15, 2019

Thank you for this @rpalcolea!
Can you please join our contributors community by signing JFrog's CLA so that we can merge your code?

@rpalcolea
Copy link
Contributor Author

@eyalbe4 oh didn’t know about the CLA

just signed it! Thanks for the heads up

Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahavi yahavi merged commit 1959cf5 into jfrog:master Oct 27, 2019
@rpalcolea rpalcolea deleted the ArtifactoryTask-proper-gradle-annotations branch October 27, 2019 16:39
@rpalcolea
Copy link
Contributor Author

Thanks @yahavi ,

any plans to do a release with these changes soon?

@yahavi
Copy link
Member

yahavi commented Nov 24, 2019

@rpalcolea,
Gradle Artifactory plugin 4.11.0 is released.
Feel free to upgrade.

@rpalcolea
Copy link
Contributor Author

awesome! thank you folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants