BuildInfoRecorder can upload "stale" POM when using maven-shade plugin #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Peter, thanks for the pull request, it looks 👍 Can you please see the "how to contribute" guide before we can merge it in? Thanks! |
|
I'm having a really hard time finding this guide, could you provide a link? :) |
|
Oh, silly me :-) here you go! http://wiki.jfrog.org/confluence/display/OSS/How+to+Contribute |
|
Done. |
OrKoren
pushed a commit
that referenced
this pull request
May 28, 2013
BuildInfoRecorder can upload "stale" POM when using maven-shade plugin
|
Pull request merged |
yahavi
pushed a commit
to yahavi/build-info
that referenced
this pull request
Dec 27, 2018
# This is the 1st commit message: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#2: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#3: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#4: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#5: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#6: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#7: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#8: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#9: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#10: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#11: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#12: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#13: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#14: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#15: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#16: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#17: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#18: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#19: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#20: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#21: HAP-1044 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#22: BI-465 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#23: BI-465 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#24: BI-465 - Support for NPM in the Jenkins Artifactory Plugin # This is the commit message jfrog#25: BI-465 - Support for NPM in the Jenkins Artifactory Plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using maven-shade plugin, the plugin tends to create a dependency-reduced-pom.xml, which basically contains a slightly modified version of the original POM (dependencies removed, or modified to have provided scope).
When using Jenkins in conjuction with artifactory-plugin suddenly the dependency-reduced-pom.xml starts to get ignored, and always the original POM gets deployed to Artifactory.
After hours of debugging I think I've nailed it down to BuildInfoRecorder#addArtifactsToCurrentModule where the deployable artifact would refer to an incorrect POM (rather than using the correct POM from the ProjectArtifactMetadata), changing that seems to resolve the problem for me. I've ran tests with single module and multi module project and the uploaded POMs looked okay as far as I could see.