Skip to content

https://www.jfrog.com/jira/browse/GAP-162 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

stormbeta
Copy link

Validate all build info tasks have executed before deploying to allow using parallel execution with the artifactory gradle plugin.

Validate all build info tasks have executed before deploying
@rupebac
Copy link
Contributor

rupebac commented Aug 14, 2015

This is actually happening to me as well. Please merge and fix this. I do not understand how is this still open since 2014.

@liorhson
Copy link
Contributor

Hey @stormbeta,
Please go to the following link, and sign the CLA paper, then we would be able to merge you pull request.

@rupebac
Copy link
Contributor

rupebac commented Jul 14, 2017

On the latest 4.5 I am still having the same problem, I see some artifactoryPublish tasks getting run after the the plugin deploys everything.

Checking your current source code, it still looks like suffering from the same problem:

private boolean isLastTask() { return getCurrentTaskIndex() == (getAllArtifactoryTasks().size() - 1); }

That is not right, and it is the same thing as @stormbeta was trying to solve. The last task may get to run before other tasks are not yet finished. This is what happens with --parallel in gradle.

The original Jira issue was just closed:
https://www.jfrog.com/jira/browse/GAP-162

It seems to me pretty crazy after so many years having the same problem. parallel is not incubating any more....

@eyalbe4
Copy link
Contributor

eyalbe4 commented Nov 14, 2017

This issue is very old, and it looks like #134 which has just been merged resolves the issue.
I'm therefore closing this issue.

@eyalbe4 eyalbe4 closed this Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants