Deterministic publish order for gradle and ivy #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort the deploy artifacts using natural comparators so that they get published to artifactory in a deterministic order.
|
This is the same as #59 , I just rebased to resolve conflicts and squashed the commits down. |
shikloshi
pushed a commit
that referenced
this pull request
Oct 14, 2015
Deterministic publish order for gradle and ivy (BI-204)
|
Hi @arothian , Thank you for your contribution. This is now merged and will be part of build-info next release. For keeping track on this issue please see Jira issue. Aviad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build extractors for Ivy and Gradle store the resulting list of artifacts to publish in a HashSet. This causes the artifacts to be published in a random order. This updates that to use a TreeSet and provides comparable implementations for related objects so that the published artifacts occur in a deterministic order. This is really helpful for us to determine when a build is complete. This would solve https://www.jfrog.com/jira/browse/GAP-181 in a more predictable manner than is currently implemented.