Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct .npmrc for newer versions of NPM #787

Open
wants to merge 12 commits into
base: npm-8.19
Choose a base branch
from
Prev Previous commit
Update NpmBuildInfoExtractorTest.java
Correct Unit Test
  • Loading branch information
Spaction committed May 28, 2024
commit 3b0f5fee90902e98b65639ede257bf4bc9affb47
Original file line number Diff line number Diff line change
@@ -10,10 +10,13 @@
import org.jfrog.build.extractor.ci.BuildInfo;
import org.jfrog.build.extractor.ci.Dependency;
import org.jfrog.build.extractor.ci.Module;
import org.jfrog.build.extractor.clientConfiguration.deploy.DeployDetails;
import org.jfrog.build.extractor.clientConfiguration.util.DependenciesDownloaderHelper;
import org.jfrog.build.extractor.npm.NpmDriver;
import org.jfrog.build.extractor.npm.types.NpmProject;
import org.testng.Assert;
import org.testng.annotations.AfterMethod;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
@@ -225,6 +228,23 @@ private String getTargetPath() {
}
}

@BeforeClass
private void setUp() throws IOException {
deployTestDependencies(Project.ASGARD, Project.MIDGARD, Project.ALFHEIM, Project.SVARTALFHEIM);
}

private void deployTestDependencies(Project... projects) throws IOException {
for (Project project : projects) {
DeployDetails deployDetails = new DeployDetails.Builder()
.file(project.projectOrigin.toPath().resolve(project.getPackedFileName()).toFile())
.targetRepository(localRepo1)
.artifactPath(project.getTargetPath())
.packageType(DeployDetails.PackageType.NPM)
.build();
artifactoryManager.upload(deployDetails);
}
}


@DataProvider
private Object[][] npmCiProvider() {
@@ -244,12 +264,13 @@ private Object[][] npmCiProvider() {
@SuppressWarnings("unused")
@Test(dataProvider = "npmCiProvider")
public void npmCiTest(Project project, Dependency[] expectedDependencies, String args, boolean packageJsonPath) {
runNpmTest(project, expectedDependencies, args, packageJsonPath, true);
runNpmTest(project, expectedDependencies, args, packageJsonPath);
}

private void runNpmTest(Project project, Dependency[] expectedDependencies, String args, boolean packageJsonPath, boolean isNpmCi) {
private void runNpmTest(Project project, Dependency[] expectedDependencies, String args, boolean packageJsonPath) {
args += " --verbose --no-audit";
Path projectDir = null;
boolean isNpmCi = true;
try {
// Prepare.
projectDir = createProjectDir(project);
Loading
Oops, something went wrong.