Skip to content

master #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

master #81

wants to merge 9 commits into from

Conversation

MadMatt04
Copy link

@MadMatt04 MadMatt04 commented Apr 15, 2016

This modification will cause the teamcity-artifactory-plugin and other tooling based on this project to not replace dependency versions in the dependency management section of the pom on artifactory release if those versions are variable-based, such as ${project.version}.

<dependencyManagement> <dependencies> <dependency> <groupId>com.marand.thinkehr</groupId> <artifactId>thinkehr-remoting</artifactId> <version>${project.version}</version> </dependency>
As in, this will be left alone.

It includes a unit test confirming the correct functionality.

Resolves https://www.jfrog.com/jira/browse/TCAP-273

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Matija Kejzar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jun 23, 2020

This PR is very old. I'm actually not sure why is was left with no updates. It surely needs to rechecked and updated. I'm closing it for now. We can create a new PR for this, if this requirement is still relevant.

@eyalbe4 eyalbe4 closed this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants