Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation internal port should not be created when federation is disabled #1849

Closed
gregoryboue opened this issue Dec 11, 2023 · 4 comments
Closed
Labels
bug Something isn't working triaged

Comments

@gregoryboue
Copy link

Since version 107.68.7 and this release :

  • Disabled federation services when splitServicesToContainers=true

The templates services now have a new internal port http-rtfs.

I think that this port configuration should not be done when artifactory.federation.enabled=false.

Version of Helm and Kubernetes:
All

Which chart:
Since 107.68.7

Which product license (Enterprise/Pro/oss):
All

What happened:

An internal port is created for artifactory federation service even if federation is disabled.

What you expected to happen:

That the port is not present in artifactory service template when ederation is disabled

@gitta-jfrog gitta-jfrog added triaged bug Something isn't working labels Dec 23, 2023
@chukka
Copy link
Collaborator

chukka commented Apr 9, 2025

Already fixed as part of 7.98.x SH release

@chukka chukka closed this as completed Apr 9, 2025
@bengaywins
Copy link

bengaywins commented Apr 9, 2025

@chukka Can you elaborate on which release please? Because we're on 7.98.9 and it definitely is not fixed. And I looked through the release notes and cannot find a reference to this being fixed.

@chukka
Copy link
Collaborator

chukka commented Apr 10, 2025

@bengaywins As I see in 107.98.9 chart , in artifactory-service.yaml


  {{- if .Values.federation.enabled }}
  - port: {{ .Values.federation.internalPort }}
    targetPort: {{ .Values.federation.internalPort }}
    protocol: TCP
    name: http-rtfs
  {{- end }}

its fixed in 107.94.x (internal release )

@bengaywins
Copy link

Great thank you! Appreciate the prompt response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

4 participants