Skip to content

Artifactory not upgradable with Flux #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktarplee opened this issue Aug 16, 2024 · 2 comments
Open

Artifactory not upgradable with Flux #1914

ktarplee opened this issue Aug 16, 2024 · 2 comments
Labels
question Further information is requested triaged

Comments

@ktarplee
Copy link

I am using Flux to install the artifactory chart. During an upgrade it looks like flux set the version of the chart to 107.90.8+2. The +2 is what is causing the artifactory helm chart issues. See this line. artifactory-107.80.8+2 is not a valid label value due to the +. IMHO the chart label should be an annotation instead since it is not used in a label selector. Alternatively it can be sanitized to be a valid label.

To reproduce this without flux simply set the version in the Chart.yaml to 107.90.8+2 then run helm install to see the error.

My current workaround is to use a post render to fix the chart.

apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
  name: artifactory
spec:
...
  postRenderers:
    - kustomize:
        patches:
          - target:
              version: v1
              kind: ConfigMap
              name: artifactory-configmaps
            patch: |
              - op: remove
                path: /metadata/labels/chart

I am using artifactory 107.90.8 and helm version v3.15.4.

@chukka chukka added question Further information is requested triaged labels Apr 8, 2025
@chukka
Copy link
Collaborator

chukka commented Apr 8, 2025

is this still an issue ? are you able to get past it ?

@ktarplee
Copy link
Author

ktarplee commented Apr 8, 2025

I believe this is still an issue. You just need to sanitize your labels in your chart here. Or simply move that line to be an annotation if you don't ever use it in a label selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested triaged
Projects
None yet
Development

No branches or pull requests

2 participants