Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure no attempts to create empty comment for PR Scan on split #848

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

attiasas
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Try to fix the following issue:

12:03:58 [Error] pull request #35 scan in the 'test' repository returned the following error:
couldn't add pull request comment: Status: 400 Bad Request, Body: {"errors":[{"context":"text","message":"Please enter a non-empty value less than 32768 characters","exceptionName":null}]}

@attiasas attiasas added the bug Something isn't working label Mar 30, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 30, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 30, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 30, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 30, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 30, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 30, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Apr 8, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my question and just to make sure the condition is valid

@attiasas attiasas merged commit ca58692 into jfrog:dev Apr 8, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants