Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude patterns expansion #403

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

hadarshjfrog
Copy link
Contributor

@hadarshjfrog hadarshjfrog commented Apr 2, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

As part of improving false positive results, we wish to ignore findings who shouldn't be scanned, as such:

  1. We wish to add a possibility to ignore partial patterns, not only folder
  2. Also - add test. to ignore the common cases in GO and JS/TS

@hadarshjfrog hadarshjfrog added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Apr 2, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 2, 2025
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will probably Break some users since you are adding more default ignores that can't be controlled or may not be intentional by the user and can't be turned off

Some tests fails, please fix them.

@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Apr 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 4, 2025
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Apr 4, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 4, 2025
@hadarshjfrog hadarshjfrog force-pushed the exclude_patterns_expension branch from 8f92110 to b133b5f Compare April 7, 2025 11:07
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Apr 7, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 7, 2025
Copy link

github-actions bot commented Apr 7, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/jas 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/jas/common.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/utils.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/jas/common_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants