Add support for OIDC token exchange in Access manager #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
4 tasks
asafgabai
approved these changes
Mar 30, 2025
asafgabai
requested changes
Mar 31, 2025
4 tasks
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
added
new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for exchanging OIDC ID tokens with access tokens in the JFrog CLI's access manager. It includes:
✅ New ExchangeOidcToken method added to AccessServicesManager
✅ Implementation of ExchangeOidcToken in TokenService, using the api/v1/oidc/token endpoint
✅ New struct CreateOidcTokenParams to represent parameters required for token exchange
✅ New struct OidcTokenResponseData to handle the response from the OIDC token exchange API
🔍 Purpose:
Enables CLI-based integration with OIDC providers by supporting the OIDC token exchange flow, as part of broader OIDC authentication support in the CLI.