Skip to content

Problem: PR #2830 breaks emails #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcollet opened this issue Mar 26, 2025 · 5 comments
Closed

Problem: PR #2830 breaks emails #2854

bcollet opened this issue Mar 26, 2025 · 5 comments
Assignees

Comments

@bcollet
Copy link

bcollet commented Mar 26, 2025

Issue

PR #2830 breaks emails as it escapes the entire body (which is html in the first place) as well as the headers (where plain-text chars such as ' or + are replace with htmlentities).

Diff example between two mails received before and after the change:

 MIME-version: 1.0
 Content-Type: text/html; charset=UTF-8
-Date: Sat, 15 Mar 2025 06:01:52 UTC
+Date: Wed, 26 Mar 2025 06:04:25 UTC
 To: benjamin@DOMAIN
-From: root+semaphore@DOMAIN
-Subject: Task 'Check configuration compliance' failed
+From: root+semaphore@DOMAIN
+Subject: Task 'Check configuration compliance' failed
 Status: RO
-Content-Length: 178
+Content-Length: 294
 Lines: 2

-<p>Task 2147481284 with template 'Check configuration compliance' has failed!</p>
-<p>Task Log: <a href="https://semaphore.DOMAIN/project/1/templates/1?t=2147481284">Link</a></p>
+&amp;lt;p&amp;gt;Task 2147481142 with template &amp;#39;Check configuration compliance&amp;#39; has failed!&amp;lt;/p&amp;gt;
+&amp;lt;p&amp;gt;Task Log: &amp;lt;a href=&amp;#34;https://semaphore.DOMAIN/project/1/templates/1?t=2147481142&amp;#34;&amp;gt;Link&amp;lt;/a&amp;gt;&amp;lt;/p&amp;gt;

Impact

Other

Installation method

Docker

Database

No response

Browser

No response

Semaphore Version

2.13.2-9d7149b-1742815416

Ansible Version

Logs & errors

No response

Manual installation - system information

No response

Configuration

No response

Additional information

No response

@fiftin fiftin self-assigned this Mar 27, 2025
@fiftin
Copy link
Collaborator

fiftin commented Mar 27, 2025

Hi @bcollet Thank you! Will fix ASAP.

@LucaMH
Copy link

LucaMH commented Apr 1, 2025

its html again, but looks like a it gets send as text

version: v2.13.7-8983a2e-1743463287 (docker)
database: mysql

Image

@stylersnico
Copy link

Hello,

+1 same here:

Image

@wdsff1
Copy link

wdsff1 commented Apr 7, 2025

same here - pls fix ;)
semaphore-2.13.10

@fiftin fiftin assigned mgukov and unassigned fiftin Apr 14, 2025
@fiftin
Copy link
Collaborator

fiftin commented Apr 18, 2025

Fixed in 2.14.0-beta3

@fiftin fiftin closed this as completed Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants