Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql Core Documentation #59

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Graphql Core Documentation #59

merged 9 commits into from
Sep 25, 2023

Conversation

bilalebi
Copy link
Contributor

@bilalebi bilalebi commented Jul 19, 2023

JIRA Ticket

https://www.ebi.ac.uk/panda/jira/browse/EA-1081

Changes

Add Graphql Core Documentation

Review deployment:

http://graphql-docs.review.ensembl.org

@bilalebi bilalebi changed the title Graphql Graphql Core Documentation Jul 19, 2023
@bilalebi bilalebi marked this pull request as ready for review September 4, 2023 08:49
@bilalebi bilalebi requested a review from azangru September 4, 2023 11:15
Co-authored-by: Ben Moore - Ensembl <bmoore@ebi.ac.uk>
@bilalebi bilalebi requested a review from Ben-Ensembl September 5, 2023 15:03
@azangru
Copy link
Collaborator

azangru commented Sep 7, 2023

@bethflint why don't we link to the core data model, which is the only place that can offer some explanation about what different things in the graph are? And, incidentally, why is the repo of the core data model still private?

@bethflint
Copy link
Contributor

@bethflint why don't we link to the core data model, which is the only place that can offer some explanation about what different things in the graph are? And, incidentally, why is the repo of the core data model still private?

Linking to it would be a good idea - but the repo needs a bit of polish before it goes public.

@azangru
Copy link
Collaborator

azangru commented Sep 8, 2023

These two links are the same link. As a reader, I would find it excessive

image

Might it be worth rewrithing the top url in full, as a string of code rather than as a hyperlink hiding behind the word "here"? https://beta.ensembl.org/data/graphql?

@bilalebi bilalebi requested a review from azangru September 13, 2023 09:48
@azangru
Copy link
Collaborator

azangru commented Sep 13, 2023

@bilalebi I'd like some decision on this

@bilalebi bilalebi merged commit b2641fd into main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants