Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature page breaks when search query param is not set correctly #5229

Open
1 of 4 tasks
tiagoapolo opened this issue Mar 14, 2025 · 2 comments · May be fixed by #5235
Open
1 of 4 tasks

Feature page breaks when search query param is not set correctly #5229

tiagoapolo opened this issue Mar 14, 2025 · 2 comments · May be fixed by #5235
Labels
bug Something isn't working

Comments

@tiagoapolo
Copy link
Contributor

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

When I navigate from my projects overview to a specific project, I see the project page for a short second and then it disappears, and left is a blank page.For the short period the project page is shown, the URL is: "https://app.flagsmith.com/project/7040/environment/UjHD9fecEp8TYGHDDqYoUG/features. It looks like "&search" is not valid. If I add "&search=" (with a "=" at the end) instead, the page shows.

Image

Sentry issue: https://flagsmith.sentry.io/issues/5016159470/?project=5666694&query=is%3Aunresolved%20expected&referrer=issue-stream&stream_index=0

Steps To Reproduce

This one is hard to reproduce in a regular flow but you can force it to happen by

  1. Go to features page
  2. Look for the search param in the URL
  3. Modify the search param to be &search instead of `&search=

Expected behavior

Page should handle query params correctly

Screenshots

No response

@tiagoapolo tiagoapolo added the bug Something isn't working label Mar 14, 2025
@Ckrill
Copy link

Ckrill commented Mar 19, 2025

Hey,
I was the one reporting this one, if you need additional info or need me to test someting, let me know. 🤙

All the best
Chris

@kyle-ssg kyle-ssg linked a pull request Mar 19, 2025 that will close this issue
4 tasks
@kyle-ssg
Copy link
Member

This is a very strange issue 😄 I can only even imagine replicating this if a browser was somehow overwriting encodeURIComponent. Regardless, the linked PR will fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants