Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dinopy: Fix pinned numpy dep; simplify recipe #28721

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbargull
Copy link
Member

Dinopy compiles against NumPy's sources and as such we need to ensure that the numpy run dependency does not use older versions as those used during build. This is done via pin_compatible. Adding an additional constraint-less numpy dependency furthermore ensures that we pick up the NumPy version from the pinnings which uses the lowest supported version. In other words: We build against the oldest possible version so that we can use any compatible newer version at run time.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@mbargull mbargull requested a review from tedil May 28, 2021 12:50
@telatin telatin self-requested a review May 29, 2021 10:06
Copy link
Member

@telatin telatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw one approval but the build is failing for:

BUILD ERROR: could not determine dependencies for recipe recipes/dinopy: Unsatisfiable dependencies for platform linux-64: {"numpy[version='1.16.*,>=1.17']"}

The recipe states, in run: pin_compatible('numpy'),
but in build build there are two lines (the latter superceding):

    - numpy
    - numpy >=1.17

@tedil
Copy link
Contributor

tedil commented May 29, 2021

I saw one approval but the build is failing for:

BUILD ERROR: could not determine dependencies for recipe recipes/dinopy: Unsatisfiable dependencies for platform linux-64: {"numpy[version='1.16.*,>=1.17']"}

The recipe states, in run: pin_compatible('numpy'),
but in build build there are two lines (the latter superceding):

    - numpy
    - numpy >=1.17

Ah, I missed that one, thought it was a substitution, not an addition.

@mbargull
Copy link
Member Author

The addition is intended but I have still have to look into why conda-build picks up 1.16.* when rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants